Skip to content

Terraform support for term#13935

Closed
Sachin-Rungta wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Sachin-Rungta:terraform-term
Closed

Terraform support for term#13935
Sachin-Rungta wants to merge 2 commits intoGoogleCloudPlatform:mainfrom
Sachin-Rungta:terraform-term

Conversation

@Sachin-Rungta
Copy link
Member

@Sachin-Rungta Sachin-Rungta commented May 13, 2025

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_dataplex_term`

@github-actions github-actions bot requested a review from c2thorn May 13, 2025 19:49
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 921 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 921 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_dataplex_term (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_dataplex_term" "primary" {
  description  = # value needed
  display_name = # value needed
  glossary_id  = # value needed
  labels       = # value needed
  location     = # value needed
  parent       = # value needed
  term_id      = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 46
Passed tests: 44
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexTerm_dataplexTermBasicExample
  • TestAccDataplexTerm_dataplexTermFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexTerm_dataplexTermBasicExample [Error message] [Debug log]
TestAccDataplexTerm_dataplexTermFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 921 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 5 files changed, 921 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))
Open in Cloud Shell: Diff ( 8 files changed, 228 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 46
Passed tests: 44
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages
  • dataplex

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexTerm_dataplexTermBasicExample
  • TestAccDataplexTerm_dataplexTermFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexTerm_dataplexTermBasicExample [Error message] [Debug log]
TestAccDataplexTerm_dataplexTermFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants